Repository navigation
perf: speed up warm compiles and upgrade Polyglot to 0.12.2 - #779
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Warm compiles rebuilt facts that were already cached; the Polyglot fork needed upstream 0.12.1 set-operation type fixes.
Changes
WITH RECURSIVE. When native binding fully resolves lineage but an output type is unknown, the native lineage is kept and types are recovered through the legacy path.Verification
make test: 6922 passed.make check-cipassed.UNION ALL/UNION ALL BY NAMEexecuted on DuckDB;