Repository navigation
perf: scale declaration scope resolution with many scoped macros - #782
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Warm compiles slowed sharply as projects added folder-scoped macros. A generated 3,000-model project with 500 used macros took about 33s to recompile unchanged, versus about 6s with 37 macros. Macro execution was negligible (499 and 2,999 call sites cost the same). The cost came from declaration-scope resolution: every SQL test was granted every macro its expected model could see, about 529,000 grant records. Those grants were then rescanned quadratically, sorted, and turned into per-test declaration contexts.
Changes
Compiled SQL, diagnostics and compile JSON are unchanged. Scope metadata no longer lists grants for macros a test never calls.
Verification
make testpasses.