Skip to content

test: stabilize fresh-process cache guards with ratio checks #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvlonge merged 2 commits into from
Sep 23, 2026
Merged

test: stabilize fresh-process cache guards with ratio checks #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6f61d4
test: recalibrate fresh-process cache budgets from two CI runs
kvlonge Sep 23, 2026
63ebd6b
test: stabilize fresh-process cache guards with ratio checks
kvlonge Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/src/sqlbuild/cli/commands/main/compile/_test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ class FreshProcessCompileCachePerformanceGuardTestCase:
expected_warm_max_wall_seconds: float
expected_edit_max_wall_seconds: float
expected_max_warm_to_cold_ratio: float
expected_max_edit_to_cold_ratio: float
expected_max_rss_bytes: int
expected_max_cache_bytes: int
expected_cold_fingerprint: str
Expand Down
28 changes: 18 additions & 10 deletions ...2e/src/sqlbuild/cli/commands/main/compile/test_fresh_process_compile_cache_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
_LOGGER: logging.Logger = logging.getLogger(__name__)
_GIB: int = 1024 * 1024 * 1024
_MIB: int = 1024 * 1024
_MAX_WARM_TO_COLD_RATIO: float = 0.67
_MAX_WARM_TO_COLD_RATIO: float = 0.65
_MAX_EDIT_TO_COLD_RATIO: float = 0.60


@pytest.mark.performance
Expand All @@ -42,10 +43,11 @@
macro_count=500,
test_count=2_945,
audit_count=5_056,
expected_cold_max_wall_seconds=12.5,
expected_warm_max_wall_seconds=6.5,
expected_edit_max_wall_seconds=6.0,
expected_cold_max_wall_seconds=14.5,
expected_warm_max_wall_seconds=8.25,
expected_edit_max_wall_seconds=7.25,
expected_max_warm_to_cold_ratio=_MAX_WARM_TO_COLD_RATIO,
expected_max_edit_to_cold_ratio=_MAX_EDIT_TO_COLD_RATIO,
expected_max_rss_bytes=2 * _GIB,
expected_max_cache_bytes=96 * _MIB,
expected_cold_fingerprint=(
Expand Down Expand Up @@ -73,10 +75,11 @@
macro_count=834,
test_count=4_908,
audit_count=8_427,
expected_cold_max_wall_seconds=24.0,
expected_warm_max_wall_seconds=14.0,
expected_edit_max_wall_seconds=12.5,
expected_cold_max_wall_seconds=23.5,
expected_warm_max_wall_seconds=13.5,
expected_edit_max_wall_seconds=12.0,
expected_max_warm_to_cold_ratio=_MAX_WARM_TO_COLD_RATIO,
expected_max_edit_to_cold_ratio=_MAX_EDIT_TO_COLD_RATIO,
expected_max_rss_bytes=2 * _GIB,
expected_max_cache_bytes=160 * _MIB,
expected_cold_fingerprint=(
Expand Down Expand Up @@ -104,10 +107,11 @@
macro_count=1_667,
test_count=9_816,
audit_count=16_855,
expected_cold_max_wall_seconds=37.5,
expected_warm_max_wall_seconds=20.0,
expected_edit_max_wall_seconds=18.0,
expected_cold_max_wall_seconds=42.5,
expected_warm_max_wall_seconds=24.5,
expected_edit_max_wall_seconds=22.0,
expected_max_warm_to_cold_ratio=_MAX_WARM_TO_COLD_RATIO,
expected_max_edit_to_cold_ratio=_MAX_EDIT_TO_COLD_RATIO,
expected_max_rss_bytes=2 * _GIB,
expected_max_cache_bytes=320 * _MIB,
expected_cold_fingerprint=(
Expand Down Expand Up @@ -187,6 +191,10 @@ def test_given_semantic_project_when_compiling_across_processes_then_cache_is_in
)
for measurement in (result.leaf_edit, result.macro_edit):
assert measurement.elapsed_seconds < test_case.expected_edit_max_wall_seconds
assert (
measurement.elapsed_seconds / result.cold.elapsed_seconds
<= test_case.expected_max_edit_to_cold_ratio
)
assert result.project_config_edit.elapsed_seconds < test_case.expected_cold_max_wall_seconds
assert result.cache_bytes < test_case.expected_max_cache_bytes

Expand Down
Loading