Repository navigation
perf: reuse compiler declaration scope in warm SQL rules - #787
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On warm compiles, compiler-integrated SQL Rules still lint files that cannot be cached (for example SQL tests or audits that call macros). That lint path rebuilt the whole SQL expansion context: it re-executed every macro module, rebuilt and revalidated the declaration scope, and re-read every project SQL file even though the compile had just done all of this.
Changes
CompileProjectInputskeeps the compiler'sDeclarationScopeBuild. Post-assembly SQL Rules lint reuses it when the discovery inputs are the same object, instead of rebuilding macros and scope.run_lint/collect_project_filesaccept file contents already read by the Rules pass, with the same selection filter.main(two builds).Verification
make testpasses (3 pre-existing failures came from a stale local native build and pass after rebuilding).make check-cigreen. One read-only review; its single concurrency finding is fixed.