Repository navigation
fix(format): make sqb format safe and idempotent - #791
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
September 23, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb formatcould not back a pre-commit fixer plus a--checkCI gate:SCHEMA (type ...)column insideMODEL(... columns (...))was detected as a secondSCHEMA()header. Format spliced in a duplicated header and the file stopped compiling.FROM VALUES (...)was rewritten toFROM (VALUES ...), which SQBRSQL039 rejects, so compile failed.--excludewithout--selectdropped SQL tests from the format scope, andpath:testscould not be combined with--exclude.descriptionmadeformatand--checkexit 1 even when nothing needed formatting.sqb formatruns to settle, soformatfollowed by--checkfailed.Changes
header-parsefault.VALUESrelation's authored form. Wrappers are matched per occurrence.--select <model>still formats only that model.description-presentis a warning. Exit status depends on faults and on pending changes for--check. Lint and Rules are unchanged.sqb formatreaches a fixed point.Verification
VALUES, strings and comments.make test(6,940 passed) andmake check-ci.format, then--checkexits 0,compilepasses, and SQL test results are unchanged.