Repository navigation
fix: skip target retention defaults for views - #793
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A target-level
time_travel_retentiondefault was applied to every model, including views. Compilation then failed with "managed time_travel_retention is not valid for views", so a target could not set a retention default for its table-backed models without annotating every view.Changes
table,incremental,snapshot), matching howdefault_table_typeworks. Other materializations resolve it as unmanaged.materialization_defaults, which wins over the target.Verification
sqb compilewith[targets.prod] time_travel_retention = "90d"passes with a view, and still fails when the view declares retention itself. The first case fails onmain.make check-cipasses, and the public-repository scan is clean.