Repository navigation
perf: plan SQL tests during warehouse inspection and skip them without tests - #796
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
September 23, 2026 16:58
kvlonge
force-pushed
the
perf/overlap-sql-test-planning
branch
from
September 23, 2026 17:09
c357096 to
c865484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb planandsqb buildplanned every selected SQL test from scratch after warehouse inspection finished, even though test planning never touches the warehouse. On a large project this took most of the "Generated plan" phase.build --no-testsplanned tests it would never run.Changes
build --no-tests, direct and virtual, no longer plans SQL tests. As a result, an invalid test fixture no longer failsbuild --no-tests; normal builds still reject it.Verification
sqb plan, 3 paired runs: "Generated plan" went from 17.6–19.3s to 3.0–4.2s. The full plan was identical tomainapart from live data-version fields, which also differ between twomainruns.--no-tests. Unit tests cover the background result, disabled planning, error propagation and the daemon worker.make testandmake check-cipass, public-repo scan clean, one review cycle with findings fixed and re-verified.