Skip to content

chore: replace dupscore with fensu dupes - #808

Merged
kvlonge merged 1 commit into
mainfrom
chore/fensu-dupes
Sep 24, 2026
Merged

kvlonge merged 1 commit into
mainfrom
chore/fensu-dupes

Conversation

@kvlonge

@kvlonge kvlonge commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Why

The duplicated-code report now ships in fensu 0.23.0 as the advisory fensu dupes command, covering more languages and running about ten times faster than the repository-local dupscore script, which no longer needs to live in (or ship with) sqlbuild.

Changes

  • Bump fensu to 0.23.0 and configure [[dupes.contract_exemptions]] in fensu.toml for the strict-adapter contract, so adapter overrides that test_strict_adapter.py forces are marked [forced] and not ranked.
  • make dupes runs fensu dupes; CONTRIBUTING.md points at fensu dupes --since origin/main.
  • AGENTS.md: new Duplicated Code section: run it before review and before adding helpers, treat it as advisory, and diagnose the wider drift a genuine duplicate indicates before consolidating.
  • Remove scripts/dupscore, its tests, console script, wheel/sdist includes and publish smoke checks.

Verification

  • fensu dupes on this branch: exit 0, 351 clusters, 355 forced members hidden; --since origin/main reports 0.
  • fensu check 0 faults; make check-ci passes.

Bump fensu to 0.23.0, configure its advisory dupes report in fensu.toml with
the strict-adapter contract exemption, point make dupes and CONTRIBUTING at it,
add AGENTS.md guidance, and remove scripts/dupscore with its console script,
wheel includes and publish smoke checks.
@kvlonge
kvlonge enabled auto-merge (squash) September 24, 2026 15:45
@kvlonge
kvlonge merged commit 122197a into main Sep 24, 2026
28 checks passed
@kvlonge
kvlonge deleted the chore/fensu-dupes branch September 24, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant