Skip to content

fix: use the current declaration layout in the playground - #820

Merged
kvlonge merged 1 commit into
mainfrom
fix/playground-current-layout
Sep 25, 2026
Merged

kvlonge merged 1 commit into
mainfrom
fix/playground-current-layout

Conversation

@kvlonge

@kvlonge kvlonge commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Why

The waffle-shop playground still used the legacy models/marts/_macros/ declaration layout while the docs teach _sqlbuild/_macros/, and the Python nodes playground imported SkipMode from an internal module instead of the public sqlbuild.tasks API. Examples built from the playground therefore mixed layouts.

Changes

  • Move the marts-only macros to models/marts/_sqlbuild/_macros/ (same exact-owner-private visibility).
  • Import SkipMode from sqlbuild.tasks in the Python nodes playground.
  • Regenerate the bundled docs skill from sqlbuild-docs, including the corrected quickstart project tree (chio-labs/sqlbuild-docs#54) and already-published janitor, plan, migrations and configuration pages.
  • Assert the current layout and public import in the playground tests.

Verification

  • Playground unit and E2E tests pass (16); the new assertions fail without the fix.
  • Generated playground compiles and builds (95 steps) with unchanged macro visibility via sqb scope.
  • make check-ci and the hygiene scan pass.

@kvlonge
kvlonge enabled auto-merge (squash) September 25, 2026 10:17
@kvlonge
kvlonge merged commit 6701700 into main Sep 25, 2026
21 checks passed
@kvlonge
kvlonge deleted the fix/playground-current-layout branch September 25, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant