Repository navigation
feat: report unsafe formatting and add join-predicate and final-CTE rules - #822
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
September 25, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb formatsilently left files unformatted whenever its safety checks failed, so--checkpassed on SQL it never formatted; on a large real project that was about 40% of files. Join keys computed insideONand free-form terminal CTE names also passed every Rule.Changes
format-unsafefault (file and reason);formatand--checkexit non-zero and a declined file is left entirely unchanged.SQBRSQL040: JOINONmust compare plain columns (literals, ranges,IS NULL,USING,ON TRUEallowed; functions, casts, arithmetic, variant paths flagged).SQBRSQL041: the last top-level CTE is namedfinaland no other CTE uses that name; fixes wrapped root queries inSQBRSQL035.Upgrade:
format --checknow reports files that were previously skipped (runsqb formatonce). Family selectors (SQBRSQL,SQBR) gain the two new Rules; exact-code lists are unaffected.Verification
make test(7,673 passed) andmake check-ci; focused formatter and Rule suites.