Repository navigation
Conversation
…merging Coordinate every transient spinner or status line with persistent terminal writes through one shared coordinator, so connection, lifecycle, and diagnostic lines clear and redraw the live line instead of landing on it. Style plan migration and scope text with the shared colour roles, make scope rows compact by default with a --verbose flag for full details, and fix singular nouns in scope and janitor summaries. JSON output is unchanged.
Share the transient line lock with the native progress projector so a reporter holding it can claim a resource terminal while another worker projects events. Pass the global --no-color flag through to scope text rendering, and describe the hollow marker as not used by this resource.
kvlonge
enabled auto-merge (squash)
September 26, 2026 12:11
auto-merge was automatically disabled
September 26, 2026 12:12
Pull request was closed
Contributor
Author
|
Superseded by #837. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb planmigrations andsqb scopehad almost no colour, so what happens to a table or what a move breaks didn't stand out. In a terminal, spinner lines could merge with other output, and several counts used the wrong plural.Changes
sqb planmigrations: bold counted headers, coloured decisions (migrate/redoblue,donedim, replaces yellow,conflict/origin missingred), dim labels and old relation,compatiblegreen. Wording unchanged.sqb scope: coloured sections and markers, and a compact default (name andfile:line, empty optional sections hidden, a marker legend).--verbose/-vrestores the full detail. JSON output is unchanged. Respects--no-colorandNO_COLOR.✓ Warehouse connectedandstatement … STARTno longer land on a live spinner in a terminal. The projector shares the coordinator's lock, which avoids a lock-order deadlock with the audit reporter.1 match,1 global collapsed,Archived 1 relationand related scope, browse and janitor counts.Verification
--verbosescope output,--no-color, coordinator ordering, plural helper, janitor wording, concurrent projector/line-lock access (hangs without the fix).sqb planandsqb testassert no transient line survives in the final screen.make check-cipasses locally.