Repository navigation
fix: run selected Python nodes against upstreams outside the run - #864
Merged
Merged
Conversation
Read-side tasks and assets now wait only for SQL resources scheduled in the current build; unselected upstreams and unmanaged sources are read as they exist, like unselected upstreams of a selected SQL model. A skipped upstream model now skips its dependent Python nodes, as it already blocks dependent models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A selected Python task or asset only ran after every declared SQL dependency reported a result in the same build. A dependency outside the run never reports one, so
sqb build --select task:xskipped the task, and a task on an unmanaged source was skipped on every build. SQL models already build against existing upstream relations when those upstreams are not selected.Changes
sqb checkno longer fakes success results for dependencies.Verification
test_python_node_selection.py(11 cases; 7 fail on the old code) covering tasks and assets selected alone, unmanaged sources, waiting on and skipping after a selected upstream, and a skipped upstream model.make test,make check-ciand the hygiene scan pass; one independent review.