Repository navigation
test: guard inspection commands on shared-dependency graphs - #874
Merged
Merged
Conversation
Add deterministic layered-diamond E2E coverage for lineage (relation and column, both directions), dag and plan output, asserting each node is expanded once and output stays linear in project size. Add fresh-process wall-time, peak-RSS and output-size guards for lineage, dag, scope and plan on the 3,000-model semantic benchmark extended with an opt-in shared-dependency lattice, run in the existing 3,000-model fresh-process compile job. The compile guard fixtures are unchanged. Refs: CHI-431
Their current cost would set the budget and add minutes to the 3,000-model job. The follow-up fixes add their own guards with tight ceilings. Refs: CHI-431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A
sqb lineagerendering bug (CHI-430) was exponential on shared dependencies and ran past 20 GB on a real project, while every CI performance guard stayed green: the guards only measuredsqb compile, and the generated benchmark had no diamond-shaped dependencies.Changes
sqb lineage(relation and column, all directions),sqb dagand thesqb plantree: each node expanded at most once, output bounded linearly.dag --jsonandscope --json, each with wall-time, peak-RSS and output-line ceilings (~42 s added).Verification
make test-e2e-cold-compile-performance SQLBUILD_BENCHMARK_MODELS=3000passes under a 4 GiB limit;make test,make check-ciand the hygiene scan pass; one independent review.