Repository navigation
perf(compile): cut cache-write overhead and fresh compile preparation cost - #882
Merged
Merged
Conversation
…-write overhead limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Writing the compile cache made cold compiles 14-18% slower than
--no-cache, and fresh compile was ~1.22x of 0.119.1. Profiling on 0.126.2 showed a whole-SQL identifier regex in binding-query preparation, dataclass construction just to serialise cache rows, full model SQL sent to native SQL-test chain resolution, and per-model scans in metadata validation.Changes
--no-cache(CPU <= 1.10, wall <= 1.15, same fingerprint). Cache job warm/edit-to-cold ratios raised to 0.70 because cold got faster while edit and warm were unchanged (to be tightened with the warm-path work).Verification
make test,make check-ci, cache and cold-compile performance targets under 4 GiB; one independent review.