Repository navigation
ci: judge release peak memory on the worst of five runs - #888
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release comparison failed the 0.126.6 release PR on
compile --no-cachepeak RSS (median 622 -> 830 MiB), but peak RSS is bimodal on both versions (~640 or ~860 MiB, depending on whether concurrent phases overlap). A 7-run local check showed the worst case did not grow (890 -> 868 MiB); the median of 3 was flipping between levels.Changes
COMPILE_BENCHMARKS.mddescribe the rule; unit tests cover the bimodal case passing, a single high candidate run failing, and a larger worst run failing.Verification
make check-ci; one independent review.