Repository navigation
fix(cli): return native allocator memory within 10 ms by default - #890
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The mimalloc allocator from #889 (v3) keeps freed memory for up to 1,000 ms before returning it to the OS. On the 3,000-model inspection benchmark,
sqb plan --jsonpeak memory rose from about 890 MB to about 1,160 MB (1.26x) in every run. That exceeds the 1.25x release comparison limit and blocks the next release.Changes
MIMALLOC_PURGE_DELAY=10(mimalloc v2's default) before it imports the CLI, which loads the native extension. A value already set by the user is kept (os.environ.setdefault).unsafe, and the root package may not run code at import time.Measured on main, plan peak RSS /
compile --no-cachewall time:Verification
sqlbuild._native; running it sets the 10 ms default when unset and preserves a user value. Both cases fail without the fix.make check-cipasses.