Repository navigation
feat(cli): add janitor --target and a --as preview - #898
Merged
Merged
Conversation
janitor --target NAME cleans up a configured target with that target's connection, namespace and state, like build --target. janitor --as NAME previews the janitor plan for another target's namespace through the active target's connection without dropping, archiving, writing state or prompting, reusing the plan --as target validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb janitorhad no--targetand always cleaned the default target, unlike every other warehouse command. There was also no way to preview a target's cleanup through another connection before running it (CHI-463).Changes
sqb janitor --target NAME: that target's connection, namespace, state and vars, the same asbuild --target.sqb janitor --as NAME: preview, likeplan --as. Compiles for NAME, inspects through the active target's connection, prints the plan, and changes nothing: no archives, drops, compatibility-view drops, audit or state writes, and no prompt.--aswith--auto-approveis a usage error.--astarget check is shared byplanandjanitor.Verification
--aslists only that target's cleanup with every table unchanged;--target ... --auto-approvecleans only its own schema; unknown targets and--as --auto-approvefail without changes.plan --astests;make test;make check-ci; one independent review (no high or medium findings).