Repository navigation
ci(release): merge a release pull request only while main is unchanged - #901
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Twice today a release pull request was merged after a newer commit had landed on main (CHI-462). That commit's Release Please run was still queued behind the running release checks, so the released package contained the commit but its changelog did not, and Release Please then treated it as released.
Changes
Verification
actionlinton the workflow.release-pleaseconcurrency group (cancel-in-progress: false): a newer push always has a queued run that updates the release pull request after this one finishes.