Skip to content

feat(format)!: layout-only token formatter with canonical SQL fingerprints #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvlonge merged 22 commits into from
Oct 1, 2026
Merged

feat(format)!: layout-only token formatter with canonical SQL fingerprints #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bf4fb71
fix(format): treat dollar-quoted literals as opaque in SQL site scanners
kvlonge Oct 1, 2026
1d7a931
feat(format): print authored SQL tokens with a parse-tree layout
kvlonge Oct 1, 2026
bde08db
perf(format): check idempotence against the existing layout oracle
kvlonge Oct 1, 2026
b2fa8aa
test(format): pin formatter output over a dialect corpus and example …
kvlonge Oct 1, 2026
e005f78
test(format): bound unformatted model formatting time
kvlonge Oct 1, 2026
99812a4
feat(planner): fingerprint compiled SQL by its canonical token stream
kvlonge Oct 1, 2026
7959a81
feat(format): wrap SQL and header audit lines longer than the line width
kvlonge Oct 1, 2026
e195637
feat(format): apply compiler-verified Rule fixes with format --fix
kvlonge Oct 1, 2026
cfa7f20
feat(format): verify Rule fixes per file and extend the safe set
kvlonge Oct 1, 2026
2191eec
fix(planner): report untokenizable SQL in column-migration planning a…
kvlonge Oct 1, 2026
ab9f7e5
fix(format): recase only keywords and built-in calls; keep dialect co…
kvlonge Oct 1, 2026
5879b1c
fix(format): fold only reserved keywords and built-in calls
kvlonge Oct 1, 2026
c42eff3
fix(format): upper-case parse-confirmed keywords; keep fingerprint fo…
kvlonge Oct 1, 2026
e818c50
test(e2e): assign formatter and fingerprint E2E files to CI shards
kvlonge Oct 1, 2026
c6b5170
feat(compile): reject built-in function spellings the dialect does no…
kvlonge Oct 1, 2026
df80a83
test(compile): cover dialect function spellings end to end and bound …
kvlonge Oct 1, 2026
ac3aaa4
docs(compile): document B101 built-in spelling checks
kvlonge Oct 1, 2026
0eabe63
fix(compile): tell built-in calls from relation and column lists
kvlonge Oct 1, 2026
8552fa8
fix(compile): treat materialized CTE column lists as non-calls
kvlonge Oct 1, 2026
40cee9f
feat(format): clause layout rules and trailing-aware line wrapping
kvlonge Oct 1, 2026
3e8960c
docs(format): describe clause layout rules and wrapping of trailing t…
kvlonge Oct 1, 2026
9499d14
fix(format): never space a function name from its parenthesis
kvlonge Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ jobs:
crates/*|Cargo.toml|Cargo.lock|pyproject.toml|uv.lock)
broad=true
performance=true
format_performance=true
rules_performance=true
;;
src/sqlbuild/compiler/*|src/sqlbuild/adapter/type_system/*)
Expand Down
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ polyglot-sql = { git = "https://github.com/chio-labs/polyglot.git", rev = "25ad0
"semantic",
"stacker",
] }
polyglot-sql-function-catalogs = { git = "https://github.com/chio-labs/polyglot.git", rev = "25ad011c49f2c7cd48f4427abb8fc0a6af2e4120", default-features = false, features = [
"dialect-duckdb",
] }
quote = "1"
rayon = "1"
regex = "1"
Expand Down
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ E2E_DUCKDB_BUILD_CORE_PATHS := \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_python_node_identity.py \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_sql_hook_identity.py \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_query_change_tracking.py \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_query_fingerprint_changes.py \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_query_propagation.py \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_remove_column_semantics.py \
tests/e2e/src/sqlbuild/cli/commands/main/build/test_reusable_model_schemas.py \
Expand Down Expand Up @@ -131,6 +132,9 @@ E2E_DUCKDB_CLI_PATHS := \
tests/e2e/src/sqlbuild/cli/commands/main/databricks \
tests/e2e/src/sqlbuild/cli/commands/main/dbt \
tests/e2e/src/sqlbuild/cli/commands/main/debug \
tests/e2e/src/sqlbuild/cli/commands/main/format/test_format_example_projects.py \
tests/e2e/src/sqlbuild/cli/commands/main/format/test_rule_fixes.py \
tests/e2e/src/sqlbuild/cli/commands/main/format/test_token_preservation.py \
tests/e2e/src/sqlbuild/cli/commands/main/freshness \
tests/e2e/src/sqlbuild/cli/commands/main/init \
tests/e2e/src/sqlbuild/cli/commands/main/rules \
Expand Down
1 change: 1 addition & 0 deletions crates/sqlbuild-rules-native/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ fensu-policy.workspace = true
globset.workspace = true
mimalloc.workspace = true
polyglot-sql.workspace = true
polyglot-sql-function-catalogs.workspace = true
pyo3.workspace = true
rayon.workspace = true
regex.workspace = true
Expand Down
Loading
Loading