Repository navigation
fix(compile): linear missing-description locations and comment-tolerant expected fixtures - #924
Merged
Merged
Conversation
…cations Locating each undescribed seed or source rescanned its whole YAML file with a per-name regex, so error-heavy compiles grew quadratically with entries per file. Index every entry name once per file and look names up from that index, preserving the outermost-entry and pattern semantics exactly.
…fixtures A comment before or after UNION ALL in an __expected__ fixture stayed attached to the neighbouring branch, so the projection scanners read the comment as an alias and reported a false P001 branch mismatch. Branch and projection splits now drop surrounding comments, alias detection ignores trailing comments, the Python fallback splitter follows the adapter's lexical syntax, and Polyglot's annotated comment wrapper is unwrapped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
UNION ALLin an__expected__SQL-test fixture raised a false P001 ("branch 2 does not match branch 1"), because the comment stayed attached to the last projection.Changes
Annotatedbranches are unwrapped.Verification
make test,make check-ci.