Skip to content

perf(compile): read SQL-test relation markers from the parse tree #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvlonge merged 1 commit into from
Oct 4, 2026
Merged

perf(compile): read SQL-test relation markers from the parse tree #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions crates/sqlbuild-rules-native/src/compiler/_helpers/sql_tests/errors.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion crates/sqlbuild-rules-native/src/compiler/_helpers/sql_tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
pub(crate) mod cte_rename;
pub(crate) mod cte_slices;
pub(crate) mod cte_sql;
pub(crate) mod errors;
pub(crate) mod expected_columns;
pub(crate) mod extraction;
pub(crate) mod helper_scope;
Expand Down
7 changes: 1 addition & 6 deletions crates/sqlbuild-rules-native/src/compiler/_helpers/sql_tests/planning.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use crate::compiler::_helpers::sql_tests::cte_slices::SliceDialect;
use crate::compiler::_helpers::sql_tests::cte_sql::{
cte_definition_sql, leading_with_prefix_end, with_leading_ctes, with_unique_ctes,
};
use crate::compiler::_helpers::sql_tests::errors::RelationMarkerError;
use crate::compiler::_helpers::sql_tests::expected_columns::expected_columns;
use crate::compiler::_helpers::sql_tests::helper_scope::{
ScopeGraph, helper_scope_ctes, merged_scoped_ctes,
Expand Down Expand Up @@ -1305,13 +1304,9 @@ fn analysis_template(
return None;
}
let expression = statements.remove(0);
let marker_calls = match relation_marker_calls(&expression) {
Ok(marker_calls) => marker_calls,
Err(RelationMarkerError) => return None,
};
Some(AnalysisTemplate {
existing_cte_names: top_level_cte_names(&expression),
marker_calls,
marker_calls: relation_marker_calls(&expression),
})
})
})
Expand Down
Loading
Loading