Repository navigation
ci: add an absolute floor to the same-runner compile ratio - #956
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
October 6, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The same-runner compile ratio job compares wall and CPU time against a 1.10x ratio only. Since unchanged warm compiles are reused (#951), warm runs take about 0.5 s, so ordinary scheduler noise (0.56 vs 0.65 s with identical CPU) exceeds the ratio. This blocked the 0.134.6 release PR, whose code is identical to its base.
Changes
--noise-floor-seconds), so sub-second runs are judged in absolute terms; the E2E test of an unattainable limit passes a zero floor.Verification
scripts/compile_performance_ratio,make check-ci.