Skip to content

docs: show a real model macro in the README example - #959

Merged
kvlonge merged 1 commit into
mainfrom
docs/readme-model-macro
Oct 6, 2026
Merged

kvlonge merged 1 commit into
mainfrom
docs/readme-model-macro

Conversation

@kvlonge

@kvlonge kvlonge commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Why

The README example test used @mock_orders(), a macro the README never explains, and its payments mock did not match the real source columns.

Changes

  • The example model uses the real cents_to_dollars macro, and the README shows its Python file from the waffle-shop example.
  • The test uses inline mock rows matching the real raw__orders and raw__payments columns, and expects the macro result.

Verification

  • The exact README model and test compile and pass with sqb 0.134.6 on a copy of the waffle-shop example; changing the expected dollars makes the test fail.

@kvlonge
kvlonge enabled auto-merge (squash) October 6, 2026 06:16
@kvlonge
kvlonge merged commit 4fa941a into main Oct 6, 2026
17 checks passed
@kvlonge
kvlonge deleted the docs/readme-model-macro branch October 6, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant