Repository navigation
fix: correct sqb mv plurals and plain-language plan bounds - #961
Merged
Merged
Conversation
…ds wording in sqb plan sqb mv and sqb rename printed "Planned edits to 1 files.", "Writing 1 files..." and "Wrote 1 files."; they now use the shared count helper. sqb plan described a model whose cursor range is found during the run as "bounds runtime-owned (model-backed cursor input)", even when that input was a seed or a source, and showed it in bold. It now names the input and its kind, for example "bounds computed at run time, once seed payments is up to date", with the same styling as the other property values. The deferred microbatch count line uses the same wording instead of "after upstream models complete". Plan JSON is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb mvandsqb renameprinted "1 files", andsqb planshowedbounds runtime-owned (model-backed cursor input)in bold, even for seed and source cursor inputs.Changes
1 file,2 files).computed at run time, once seed payments is up to date, styled like the other properties. The deferred microbatchbatchesline uses the same wording.Verification
fensu checkandmake check-ci.