Repository navigation
fix: no traceback after failed builds, and aligned test statuses - #962
Merged
Merged
Conversation
The compute log tees called their failure callback with the error positionally, but ScopedComputeLogCapture bound _report with a keyword-only error, so any capture write failure raised TypeError. After an early planning or compile failure the transient status line was left running; its atexit close then wrote through the stale stdout tee to closed storage and printed the TypeError as an ignored exception. Report write failures through a matching one-argument method, detach the tees when capture ends so late writers reach only the terminal, and clear any live transient line before the dispatch error is reported.
Expectation rows under a failing test are indented further than their parent row but padded to the same name width, so their PASS/FAIL sat four columns to the right. Pad tree child names by their extra indentation in sqb build and sqb test, include that indentation when sizing the name column so long expectation names still align, and align the nested error label with the expectation names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A build that failed early (a compile error, or missing upstream models) ended with an "Exception ignored ... TypeError" traceback. Separately, the PASS/FAIL statuses of test rows and their expect rows sat in different columns in
sqb buildandsqb testoutput.Changes
sqb build) and insqb testare padded for their tree indent, so statuses line up with the parent row, including long names; theerrorlabel lines up with the expectation names.Verification
fensu checkandmake check-ci.