Repository navigation
fix(snowflake): create state tables permanent with maximum time travel - #964
Merged
Merged
Conversation
…o a same-tick rewrite cannot flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Snowflake, SQLBuild's
_sqlbuild_*state tables were created TRANSIENT with no retention setting, so they had at most one day of time travel and no fail-safe; the microbatch state table was created permanent through a separate path. Losing state history means losing run, audit, freshness and fingerprint records (CHI-517).Changes
CREATE TABLE IF NOT EXISTS … DATA_RETENTION_TIME_IN_DAYS = 90(the Enterprise maximum). If the account rejects 90 (Standard edition allows 1), that statement is retried once with 1, remembered per database and schema; the successful retry reports as one successful statement.Verification
make test,make check-ci.