Repository navigation
fix: show statement and step progress rows only with --debug - #967
Merged
Merged
Conversation
Build and test printed a persistent 'statement ... START' row for every warehouse statement, in a terminal and in redirected output. Statement start and query-ID submission rows now appear only with --debug. Slow statement heartbeats and statement failures are still shown, so long warehouse queries keep a live signal with their query ID.
Build, test, load and seed printed a START and OK row for every step inside a resource (staging creation, promotion, loader calls, audit evaluation, SQL test assertions), in a terminal and in redirected output. These rows now appear only with --debug; a failed step still prints its FAIL row. In a terminal, resources without a dedicated progress row no longer print a START row by default, and sqb seed no longer prints a second result row for each seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A passing
sqb buildprinted hundreds of permanent progress rows: astatement … STARTrow for every warehouse statement, and START/OK rows for every internal step (staging, promotion, loader calls, audit evaluation, test assertions).sqb seedalso printed every seed twice.Changes
--debug. Statements still running after 30s and failed statements still print, with their query IDs.--debug, in a terminal and in redirected output. A failed step always prints its FAIL row.--debug. Redirected output keeps one START row per resource, so logs show what is running.sqb seedregisters its seeds with the progress printer, so each seed prints once.Verification
build,seedandtestshowing no START or step rows, and--debug buildshowing them.fensu checkandmake check-ci.