Repository navigation
fix: make model: and column: prefixes optional in sqb rename and sqb mv - #970
Merged
Merged
Conversation
Resolve rename and mv targets with the same resolver sqb lineage uses, so a bare <model> renames or moves the model and <model>.<column> renames the column. Prefixed forms keep working. Targets naming a source, seed or function, or a prefix that contradicts the resource, fail with C954 and say what was found. sqb lineage now also accepts the column: prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb renameandsqb mvrequiredmodel:andcolumn:prefixes, sosqb rename stg_orders.amount revenueandsqb mv fact_orders models/reporting/failed, whilesqb lineagealready accepted bare targets.Changes
sqb renameandsqb mvaccept bare<model>and<model>.<column>targets; the prefixes still work.sqb lineage, which now also accepts thecolumn:prefix.column:has no column, orsqb mvgets a column.Verification
mv.fensu checkandmake check-ci.