Repository navigation
fix: make sqb lineage use the shared selector parser - #972
Merged
Merged
Conversation
sqb lineage --select/--exclude now resolve through the same selector implementation as compile, plan and build, so path:models/... selectors, name globs and shared error codes behave identically across commands. The undocumented lineage-only path:<folder> form without the models/ root is now rejected with S012, matching every other command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb lineage --selectused its own selector parser, which disagreed with compile, plan and build:path:models/staging(the documented form) failed in lineage,path:stagingworked only there, and globs such asstg_*were unsupported.Changes
sqb lineage --select/--excludeuses the shared project selector parser and resolver; positional<model>/<model>.<column>targets are unchanged.source:raw_*), backslash paths andmodels/-rooted bare paths, and reports the shared S002 to S012 errors.path:stagingwithout a root is rejected with S012 in lineage, as in every other command.Verification
sqb lineageandsqb compileselect the same models for the same selectors.fensu checkandmake check-ci.