Repository navigation
Conversation
Polyglot 1cb2a731 keeps a CTE's or derived relation's columns in output order, so a column alias list renames each column to the type it has. Before, the alias types followed hash order and changed between runs.
Contributor
Author
|
Not needed: SQLBuild analysis is moving to SQLQuack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Polyglot's type annotation kept a CTE's or derived relation's columns in a hash map. A column alias list renames columns by position, so in
FROM o AS t(a, b)each alias could take another column's type, and the types changed between runs. SQLBuild pins SQLClean and polyglot together, so both need the fixed polyglot to keep a single copy in its build.Changes
polyglot-sqlandpolyglot-sql-function-catalogsto 1cb2a731 (fix: keep scoped relation columns in output order for column aliases polyglot#43), which keeps scoped relation columns in output order. It is cut from the commit pinned before, 8767d688, so it brings no other polyglot change.Verification