Repository navigation
fix(deps): pin SQLQuack f9e4ae6e; Databricks and SQLite fingerprints of queries with columns named ANY, SOME, ORDER, FOR or WITH change once, as those names now keep their case - #53
Merged
Conversation
…of queries with columns named ANY, SOME, ORDER, FOR or WITH change once, as those names now keep their case SQLQuack f9e4ae6e gives fingerprints a Databricks feature, which SQLClean now enables; without it Databricks fingerprints fail. The format corpus, its fingerprints and lint outputs are unchanged from 0.6.3.
Deploying sqlclean with
|
| Latest commit: |
01447e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://539af378.sqlclean.pages.dev |
| Branch Preview URL: | https://fix-pin-sqlquack-f9e4ae6e.sqlclean.pages.dev |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pin SQLClean to SQLQuack f9e4ae6e. Its fingerprints have a Databricks feature, so SQLClean must enable it, or every Databricks
query_fingerprintfails ("built without the feature for Databricks").Changes
sqlquack-fingerprintgains thedatabricksfeature.Verification
format_jsonat no width and at 80,query_fingerprintandlint_json(postgres also linted as generic and sqlite), 4,538 lines. Output iscmp-equal to v0.6.3. Without the feature, all 62 Databricks fingerprints fail and nothing else differs.select any, some, order from t,SELECT any, some, `order` FROM t,select any from t where some > 1 order by orderselect for, with from tselect a.any, b.some, c.order from t aandselect count(*) from tin both, and every probe in generic, postgres and duckdbcargo build -p sqlcleanpasses. Verify runs on this pull request.