Repository navigation
fix(deps): pin SQLQuack f53c6a07, the new root of SQLQuack main - #55
Merged
Merged
Conversation
The crates SQLClean builds have the same trees at f53c6a07 as at f9e4ae6e, so formatting, lint and fingerprints do not change.
Deploying sqlclean with
|
| Latest commit: |
8aecde8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23976f63.sqlclean.pages.dev |
| Branch Preview URL: | https://fix-pin-sqlquack-f53c6a07.sqlclean.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack main was replaced by a new root, f53c6a07, so SQLClean now pins that commit. The old pin, f9e4ae6e, still resolves through a retained branch. Downstream crates cannot pin the new root until a released SQLClean does, because Cargo would see two revs of the same SQLQuack git URL.
Changes
sourcelines of the 11 SQLQuack packages change.User-visible behaviour does not change. The SQLQuack library crates SQLClean depends on (all 11 in its closure) and SQLQuack's root Cargo files are unchanged between the two revs. f53c6a07 differs from f9e4ae6e only in moving evidence data out and in 3 test helpers of the SQLQuack CLI crate.
Verification
cargo tree --locked -p sqlclean: sqlquack-derive, -fingerprint, -format, -lint, -parse, -syntax, -syntax-bigquery, -syntax-databricks, -syntax-postgres, -syntax-snowflake and -syntax-sqlserver all resolve torev=f53c6a07…#f53c6a07.cargo test --all --locked: 49 passed, 0 failed.git diff f9e4ae6e f53c6a07over the 11 crate directories, Cargo.toml, Cargo.lock, rust-toolchain.toml and .cargo is empty.