Repository navigation
fix(deps): pin SQLQuack 0.5.1 - #65
Merged
Merged
Conversation
Move every sqlquack-* pin from c0327785 (0.5.0) to e1a583eb (0.5.1) so SQLBuild can link one SQLQuack copy with its DuckDB and LATERAL analysis fixes. No source changes.
Deploying sqlclean with
|
| Latest commit: |
16075f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5af9ca9a.sqlclean.pages.dev |
| Branch Preview URL: | https://fix-pin-sqlquack-051.sqlclean.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.5.1 (
e1a583eb, tag v0.5.1) fixes false analysis errors on DuckDB and other dialects: LAG and LEAD with one to three arguments, comma-joined and nested LATERAL subqueries, lambdas in grouped queries, and DuckDB JSON and time-zone typing. SQLBuild needs these fixes. It links SQLClean and SQLQuack into one binary, so SQLClean has to pin the same revision for the build to keep a single SQLQuack copy.Changes
Cargo.tomlandCargo.lock: all six directsqlquack-*pins (11 locked packages) move fromc0327785(0.5.0) toe1a583eb6d4180ff4121ef82b3f08b2982edca66(0.5.1).Verification
query_fingerprintand lint with every catalogue rule. 80,010 of the 81,011 records are byte-identical toc0327785's. The one that changes is the expected fix: lint on a truncated Databricks query (WITH t AS (SELECT 1) SELECT * FROM) used to panic and now returns diagnostics.cargo fmt --checkandcargo clippy --all-targets -- -D warningsare clean.cargo test --release --workspace --locked: 48 passed.