Repository navigation
Conversation
Replace the early skeleton with small crates: sqlquack-core (parsing, construct classification, refusals, tree comparison and both re-parse checks), sqlquack-rules (empty catalogue), sqlquack-snowflake, sqlquack-duckdb and sqlquack-compare (empty), and sqlquack (pipeline, census and command line). Polyglot is pinned without its transpile feature.
make check-ci runs rustfmt, clippy with -D warnings, fensu with the Rust rule pack, ruff and ty. CI runs check-ci and the tests with a cached dependency build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
P0 of SQLQuack (CHI-831). It turns the May skeleton into the real workspace. Every construct is refused with a structured reason, and the quality gates block merges from the first commit.
Changes
sqlquack-core(guarded parsing, classification, refusals, tree comparison, both re-parse checks),sqlquack-rules(empty catalogue), stub crates for snowflake, duckdb and compare, and thesqlquackfacade with thecensuscommand.transpile.make check-ci(fmt, clippy-D warnings, the workspace lints, ruff, ty, fensu), a pinned toolchain, and CI with a cached dependency build.Verification
make check-ciandmake testpass locally, and the hygiene scan is clean.