Repository navigation
coverage: land the auditor's renewed trunc2 review - #108
Merged
Merged
Conversation
Only change: sf.functions.trunc2 unverified -> verified, back to 2,388 verified forms; every other snapshot field is identical.
The auditor corrected reviewed_utc to 2026-11-06T07:26:55Z (c11cf5b); fingerprint, definition and parser tree are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the auditor's D118 renewal of sf.functions.trunc2 after #104. Coverage-only.
auditor-functions-020, copied as written from the[landing]table of coverage/syntax/audits/d118-findings-219a540d.toml (60c6cc4 on wip/syntax-omission-audit). Fingerprint 72e47302…, definition 68b34fd7… (unchanged), parser tree cc21b65e.snapshot. The only change is sf.functions.trunc2 unverified → verified, so main is back to 2,388 verified forms.diffagainst the old baseline: 3,479 forms, 0 problems, forms gained (1): sf.functions.trunc2.The auditor's reading: receipt ka4427f986c78 (
TRUNC(1, DAY)) is errno 904 after parsing, so Snowflake resolves DAY as an identifier, and the column node is the faithful tree. That supersedes only the TRUNC part of finding d704778.