Repository navigation
Conversation
They share LEAST/GREATEST's rule, skipping NULLs as DuckDB's own greatest/least do, NULL only when every argument is. They join fn:GREATEST and fn:LEAST in numeric_range's constructs. Recorded cases t001, t003, t004 and t005 of both files now match; t002 (text first beside a number) stays refused by text_number_scale.
Contributor
Author
|
Closing: SQLQuack lands through local-gate trains, not PR merges (D94), so open PRs only add clutter (D628/D630). The branch is kept. Any work here that isn't on main yet is tracked by the train owner and lands through a train. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #98 (
fix/d215-lag-lead); review this diff against that branch.What changes
GREATEST_IGNORE_NULLS and LEAST_IGNORE_NULLS now convert. They share the LEAST/GREATEST rule and skip NULLs as DuckDB's own
greatest/leastdo, returning NULL only when every argument is NULL. Both joinfn:GREATESTandfn:LEASTinnumeric_range's constructs in sqlquack.toml.Evidence
greatest-ignore-nulls.tomlandleast-ignore-nulls.tomlnow match. t002 (text first, beside a number) stays refused bytext_number_scale, per the coordinator's ruling.The D94 gate runs on the landing head after #98 lands.