Repository navigation
docs(site): print the homepage's convert output one clause per line - #126
Merged
Merged
Conversation
Re-run on main ff9ff20 in a folder with no sqlquack.toml: the hero, the decimal and HASH examples now show the clause-per-line layout, the hero's summary names the built-in default, and the HASH refusal's help line is the one the built-in policy prints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124 (D265). Every convert output printed on the homepage, re-run on main ff9ff20 in a fresh folder with no sqlquack.toml (section 04 uses the repository's sqlquack.toml with
hashset towarn):sqlquack convert revenue.sql --schema schema.jsonnow prints SELECT on its own line with 4-space items, and the summary reads "done, converted under the built-in default" (since feat: use the built-in policy when there is no policy file #120).hash…").echo "SELECT 1 AS total" | sqlquack convertstays on one line (60 characters or fewer).The docs pages (index, quickstart, convert, python) were already updated in #124 and match the real output.
Checks: build_engine, build, check_figures, check_links (17 pages, 0 broken), test:engine 7/7, generate_diagnostics --check. The playground was checked at 1280 and 390 against this build with DuckDB-WASM: valid and decimal pass all four stages, and the rows equal the
--compactoutput run in native DuckDB.