Repository navigation
syntax: share Gap/Parsed and pick the checker's local parser per dialect - #136
Merged
Merged
Conversation
… parser per dialect Gap and Parsed move from sqlquack-syntax-postgres into sqlquack-syntax so a second native dialect parser returns the same shape; the Postgres crate re-exports them unchanged. The receipt checker maps each LocalParser to its verdict through local_verdict, and parse-worker takes --parser instead of --postgres, so a new dialect parser is one enum variant and one match arm.
Contributor
Author
|
Proof gate on the exact head
Postgres figure unchanged: 1,384 of 1,555 forms (89.0%), 19,346 of 22,726 obligations, 0 problems (parser tree d95965e3; the tree id moves only because Main has since moved; the landing re-merges main and re-gates the exact head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared groundwork for a second native dialect parser.
GapandParsedmove fromsqlquack-syntax-postgresintosqlquack-syntax(modes::models), unchanged in shape; the Postgres crate re-exports them, so its public API is the same.LocalParserto its verdict throughlocal_verdict; the hiddenparse-workertakes--parser <snowflake|postgres|none>instead of--postgres. A new dialect parser is one enum variant and one match arm.No Snowflake path changes behaviour; the landing gate (check-ci, test-rust, Snowflake checker byte-identity with summary/stale, verify-recorded,
results --againstmain, lineage) will be posted here.