Skip to content

Settle ten cases from receipts already on main - #143

Closed
kvlonge wants to merge 1 commit into
mainfrom
fix/pending-case-settlements
Closed

kvlonge wants to merge 1 commit into
mainfrom
fix/pending-case-settlements

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Rebuilding the cases settles ten cases whose receipts are already on main. No case is added or removed, and no SQL, setup or session changes. This PR lands those settlements so that main's case files match what the builder produces.

Generated with python -m scripts.build_syntax_cases ddl dml query utility expressions --receipts coverage/syntax/receipts --held coverage/syntax/held.jsonl and #142's setup-lookup fix applied. Main's builder can't regenerate these files on its own: it falls back to the wrong run-database setup for about 60 create-warehouse cases and 13 IPADDRESS/UUID cases, which also makes some of these settlements miss. This PR doesn't include that fix; it should land after #142. The other five families rebuild unchanged.

Case Obligation Change
sf.ddl.alter-stage.set.syntax.k3348a58b337a o600 observe → reject
sf.dml.copy-into-location.kc075e88d4ac6 o535 observe → reject
sf.dml.copy-into-table.internalstage-externalstage-externallocation.kd9524c95ea90 o718 observe → reject
sf.utility.call-with.table-language-sql-as.k48740c5f6218 o107 observe → accept, stage semantic
sf.utility.call-with.table-language-sql-as.k5745e852431d o108 observe → accept, stage semantic
sf.utility.call-with.table-language-sql-as.k56117592b40d o109 observe → accept, stage semantic
sf.ddl.alter-application.set.k58044f9d26e1 o036 accept: stage semantic added
sf.ddl.alter-pipe.set.kea320864933d o043 accept: stage semantic added
sf.ddl.alter-stage.set.syntax.k74020578524f o615 accept: stage semantic added
sf.query.order-by.orderitem.k6b0adc60d0fe o024 accept: stage semantic added

The marks files gain the matching six "settled" rows. The stage is informational and is never scored.

syntax-coverage diff coverage/syntax/baseline.json:

  • Forms gained: none. Forms lost: none.
  • Obligations gained (5): sf.ddl.alter-stage.set.syntax.o600, sf.dml.copy-into-table.internalstage-externalstage-externallocation.o718, and sf.utility.call-with.table-language-sql-as.o107, o108 and o109.
  • Obligations lost: none.
  • sf.dml.copy-into-location.o535 goes from awaiting_observation to disagreement. Snowflake rejects COPY INTO 'azure://…' FROM v1 = ( ) ; as a syntax error, but the parser accepts it. That's a parser gap, now visible, not a regression.
  • The checker binary was built from Refuse typed timestamp literals Snowflake rejects #142's crates. None of these cases touch typed literals, and the gate re-runs the diff on the exact head.

Draft: waiting on the audit and a slot after #142.

A rebuild with the case builder settles ten cases whose receipts landed without a rebuild:
six observed cases take the expect their receipts agree on (three reject, three accept with
a semantic stage), and four accepted cases gain the semantic stage their receipts record.
No case is added or removed and no SQL, setup or session changes.

kvlonge commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Closing: SQLQuack lands through local-gate trains, not PR merges (D94), so open PRs only add clutter (D628/D630). The branch is kept. Any work here that isn't on main yet is tracked by the train owner and lands through a train.

@kvlonge kvlonge closed this Nov 8, 2026
@kvlonge
kvlonge deleted the fix/pending-case-settlements branch November 9, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant