Repository navigation
website: add the social preview image and use absolute image URLs - #146
Merged
Merged
Conversation
The pages pointed og:image at /assets/og-sqlquack.png, which did not exist, and the home page and playground used a relative URL that many link unfurlers ignore. Add the 1200x630 card in the style of the other SQLStack sites, point og:image and twitter:image at https://sqlquack.io/assets/og-sqlquack.png on every page, and give the docs pages the same image alt text.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Website-only change. sqlquack.io had no working social preview:
og:imageandtwitter:imageat https://sqlquack.io/assets/og-sqlquack.png, which did not exist (404).og:image(/assets/og-sqlquack.png), which many link unfurlers ignore, and had notwitter:image.This adds
website/public/assets/og-sqlquack.png(1200×630, 138 KB), laid out like the SQLBuild and Fensu cards: the SQLQuack logo, the home-page headline, a short convert/refuse terminal, and the tagline "Verified results, or a clear no." in the yellow accent. Every page now has absoluteog:imageandtwitter:imageURLs andtwitter:cardsummary_large_image(Starlight already emits it on the docs pages), and the docs pages also get the image alt text.No engine or converter changes.
Checked locally:
./scripts/build_engine.sh,npm run -s test:engine(12 pass),npm run build, andpython3 scripts/check_links.py dist(0 broken links). The built/,/playground/and/docs/all carry the absolute image URLs.