Repository navigation
Conversation
A keyword such as OFFSET or LIMIT used as the alias of an ASOF JOIN table, before MATCH_CONDITION, became an identifier with no span, so a located parse could not point at it. It now carries the alias token's span.
kvlonge
added a commit
that referenced
this pull request
Nov 7, 2026
…rejection messages at 316d770 approved
Contributor
Author
|
Closing: SQLQuack lands through local-gate trains, not PR merges (D94), so open PRs only add clutter (D628/D630). The branch is kept. Any work here that isn't on main yet is tracked by the train owner and lands through a train. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A keyword used as the alias of an ASOF JOIN table before MATCH_CONDITION (
… ASOF JOIN y OFFSET MATCH_CONDITION (…), likewiseLIMIT) became an identifier with no span, so a located parse could not point at it.parse_join_table_suffixnow gives the alias the span of its token.test_locatedrow forSELECT * FROM x ASOF JOIN y OFFSET MATCH_CONDITION (x.t >= OFFSET.t). It fails on main with "the node has no span" and passes with the fix.cargo test -p sqlquack-syntax: all pass.cargo fmt --check: clean.parser_tree(7fa8e1ec → 69c7c6be).diff,staleandsummaryexit 0, so no verdict, obligation or review entry changes.Landing waits for a merge slot; the full gate runs on the merged head then.