Repository navigation
docs: credit Polyglot and SQLGlot for the parser SQLQuack forked - #171
Merged
Merged
Conversation
The README says where SQLQuack's parser comes from and adds a Credits section for Polyglot and SQLGlot. The credits page says the same. THIRD_PARTY_NOTICES now names the parser as a modified fork of polyglot, in sqlquack-syntax-snowflake, sqlquack-syntax and sqlquack-derive. It gives the current paths of the ported DuckDB result-type rules and their fixture, and lists the semantic checks ported from polyglot's validation. The licence texts are unchanged, and the distribution copies match the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack's tokenizer, parser and syntax tree are a modified fork of Polyglot, which is a Rust port of SQLGlot. This PR says so plainly and credits both projects.
Changes
/docs/credits/): rewritten to match the README. It keeps the note that SQLGlot's Snowflake test suite supplies case inputs.python/andcrates/sqlquack/:crates/sqlquack-syntax-snowflake(most of the derived code),crates/sqlquack-syntaxandcrates/sqlquack-derive. A line-overlap check against Polyglot's source finds derived code only in those three crates; the othersqlquack-syntax-*crates are SQLQuack's own parsers.crates/sqlquack-semantics/src/duckdb/profile/_helpers/typing.rsand to the fixture's current location.families.rs,signatures.rs,scope_rules.rs,node_checks.rs,relational.rsandsets.rsincrates/sqlquack-semantics/src/lineage/_helpers/checks.Verification
Checks run locally: site build and link check (22 pages, 0 broken links), the diagnostics and known-differences generators with
--check,make distribution-notices, and a script confirming that every path the polyglot section names exists.