Repository navigation
docs: credit only the integer widening rule of DuckDB typing to Polyglot - #173
Merged
Merged
Conversation
kvlonge
force-pushed
the
docs/notices-typing-provenance
branch
from
November 11, 2026 09:13
86d7b36 to
550500f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The polyglot notice said SQLQuack's DuckDB result-type rules and their engine-types fixture are ported from Polyglot. They are not: both were written in SQLQuack's own fork of Polyglot and were never part of upstream Polyglot. The one piece of the typing code that does come from upstream is DuckDB's widening of a signed integer mixed with an unsigned one.
Changes
python/andcrates/sqlquack/copies): creditsunsigned_coercionincrates/sqlquack-semantics/src/duckdb/profile/_helpers/duck_types.rsto Polyglot.typing.rsandduckdb_engine_types.jsonare now described as SQLQuack's own, written in its fork of Polyglot and never part of upstream Polyglot. The credit for the semantic checks, the parser and the licence texts is unchanged./docs/credits/): it now names the semantic checks and the integer-widening rule as ported, and says the typing is SQLQuack's own, matching the README.Verification
Site build and link check (22 pages, 0 broken links),
make distribution-notices, a script confirming that every newly named path exists, and the public-repository hygiene scan.