Repository navigation
refactor(syntax): drop the lowered call mode - #177
Merged
Merged
Conversation
CallMode::Lowered reproduced Polyglot's call lowering for the removed equivalence check. Nothing outside the parser's own tests and nested procedure bodies of a lowered parse used it, so the parser now always keeps Snowflake calls as written, and the config flag that switched it goes too. Standalone type parsing, which used the flag's default, follows the same path; every corpus verdict is unchanged. The ported test that read TRY_TO_NUMBER's lowered precision and scale goes with the mode. The tests that compared the two modes now assert the node each call keeps: keyword syntax stays typed, kept calls stay calls, and DuckDB keeps its typed nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CallMode::Loweredreproduced Polyglot's call lowering for the equivalence check. That check is gone, and nothing else uses the mode. It is the last parser code whose only job was to match Polyglot.Changes
CallMode::Loweredand the parser config flag that switched it. The parser now always keeps Snowflake calls as written, including in nested procedure bodies.TRY_TO_NUMBER's lowered precision and scale.Verification
make check-ci RECORDER=0 EVIDENCE_BASE=origin/mainpasses on this head.