Repository navigation
fix: point and word the playground's common syntax and alias errors clearly - #181
Merged
Merged
Conversation
… the clause GROUP or ORDER before BY read as a column name, so a condition left open before the clause, as in the playground's syntax error example, failed one token late, at BY. GROUP or ORDER before BY now always starts the clause, and the error points at it.
…ession belongs A statement that ended where an expression belongs, such as an empty WHERE, reported the token before the gap: "Unexpected token: Where". It now says what is missing: a condition after WHERE, HAVING, QUALIFY or ON, and an expression after anything else, such as an operator.
…iased column message The SQ0009 label named the internal node kind, such as `j_s_o_n_extract`, and its help suggested an alias guessed from the text under the span. For a path that was only its first name, and for a literal a quoted copy of the literal. The label now reads plainly, and a literal or path gets the help to add an alias without a guessed name.
kvlonge
force-pushed
the
fix/snowflake-clause-keyword-columns
branch
from
November 11, 2026 19:10
a54615e to
3eea2bc
Compare
test_fixes.rs grew past the 2,000-line limit once main's tests joined it; the tests that check where a parse error points and what it says move to test_parse_errors.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The playground's first impressions had three rough edges:
j_s_o_n_extract). Its help guessed a wrong alias for paths ("PAYLOAD"forpayload:page) and a quoted copy for literals.Changes
One commit each:
Verification
analyzewith its default settings. No outcome or converted SQL changed; 67 messages changed, all as above.make check-cipasses.