Repository navigation
fix(syntax-receipts): import execute runs that have no run database - #186
Merged
Merged
Conversation
A capture run that executes each case once in a fresh session, without a run-owned database, names its capture in the start event but uses neither the scripting submission nor the compile-only EXPLAIN method, so the importer refused the whole run as matching no known driver. The packet driver already reads such runs, with an empty setup; it now handles them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The receipt importer refused every capture run that executes each case once in a fresh session with no run-owned database, because its start event names the
executecapture but neither the scripting submission nor the compile-only EXPLAIN method. Two such runs (6 rows) went unimported.Changes
"capture": "execute"and a packet hash goes to the packet driver, which already reads these runs with an empty setup. Ddl runs still match first by their run database.Verification
uv run pytest tests/unit/scripts/syntax_receipts: 75 passed. The new test fails without the fix.make check-ci RECORDER=0passed on this head.