Repository navigation
fix(syntax-coverage): fail on a not-submitted entry whose case has a receipt - #190
Merged
Merged
Conversation
…receipt An unobservable entry with cause = "not_submitted" keeps its obligation unverifiable whatever its cases' receipts, so obligations stayed unsatisfied after their cases were recorded. The check now fails when a listed case has a current syntax receipt with its sql_sha256, and the 3,545 such entries are removed, with evidence pinned to 742cb3eb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An unobservable entry with
cause = "not_submitted"keeps its obligation unverifiable whatever its cases' receipts. 3,545 of those entries list a case that has since been recorded, so the published baseline understates coverage, and nothing caught the stale entries.Changes
sql_sha256(superseded, withdrawn and measure receipts don't count), so the receipt decides the obligation. A negative test fails without the rule.Satisfied obligations in the syntax baseline:
The 1,573 gained: 1,488 from the lifted entries and 85 from batch 5's receipts; none lost. The other 2,057 lifted obligations now take their receipts' reason, such as a disagreement or an opaque fallback, for the grammar work to judge.
Verification
syntax-coverage snapshotrefuses the tree with the old entries back ("a snapshot of a tree with problems claims nothing").make check-syntax DIALECT=snowflake: 3,479 forms, 0 problems.make verify-recordedandmake check-cipass.