Repository navigation
ci(release): open the release pull request with the delivery app - #192
Merged
Merged
Conversation
Release Please used github.token, so the release pull request it opened started pull request runs only after manual approval, and the organization auto-merge workflow did not treat it as the delivery app's. It now mints the delivery app token, as SQLBuild does, and passes it to release-please-action, keeping github.token when the App's variable is not set. Publish and the dispatched release checks keep github.token. The clutter guard allows the App's key name only in the release workflow, and only while that workflow has no pull request trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release Please opens the release pull request with
github.token. A pull request opened with that token starts nopull_requestruns, so its required checks have to be dispatched separately. When the branch is regenerated, thepull_requestruns wait for manual approval. The organization's delivery app avoids both, as it already does for SQLBuild.Changes
release-please.ymlmints a delivery app token withactions/create-github-app-token, scoped to this repository, and passes it torelease-please-action. Whenvars.CHIO_DELIVERY_APP_IDis not set, the step is skipped and Release Please keepsgithub.token. Publish and the dispatched release checks keepgithub.token.release-please.yml, and only while that workflow has nopull_requestorpull_request_targettrigger. Negative tests fail if the name appears in any other file, or if the workflow gains a pull request trigger.Verification
make check-cipasses.