Repository navigation
fix(syntax-cases): render external table options and DCM environments as documented - #193
Merged
Merged
Conversation
… as documented The CREATE EXTERNAL TABLE stage forms gave every positive case the all-options shell, which pairs OR REPLACE with IF NOT EXISTS (the docs forbid both) and carries WITH CONTACT, so 27 accept cases failed for a clause they did not test. They now render unpacked, like the other receipt-checked forms. Unpacked, three option-absent WITH CONTACT cases render the same SQL as their positive case, so those obligations are withdrawn. EXECUTE DCM PROJECT ... ENVIRONMENT takes a bind variable, so the generated cases fill it with ? instead of an identifier.
…e and DCM cases Pins evidence fd3882ee: the syntax receipts for unreceipted, DCM and CALL ... WITH cases, and the recorded cases the previous commit regenerates. 587 not_submitted entries now list a case with a receipt and are removed. Six more now name the two unpacked external table cases that still carry INTEGRATION and stay held. Marks and the syntax baseline are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
27 CREATE EXTERNAL TABLE cases were labelled accept, but Snowflake rejected all of them with a syntax error, leaving 268 obligations with an unexpected outcome. Their stage forms gave every positive case the all-options shell. That shell pairs OR REPLACE with IF NOT EXISTS, which the docs forbid, and carries WITH CONTACT, which Snowflake rejects on external tables. So each case failed for a clause it did not test. EXECUTE DCM PROJECT ... ENVIRONMENT also takes a bind variable, but the generator filled it with an identifier.
Changes
<bind_variable>with?.Satisfied obligations in the syntax baseline:
None are lost. WITH CONTACT on CREATE EXTERNAL TABLE stays a documented clause that Snowflake rejects.
Not in this change: the hand-written DCM ENVIRONMENT cases in
limits.tomlstill use an identifier and need( ? )and a new recording.Verification
syntax-coverage snapshot: 3,479 forms, 0 problems.make verify-recorded: 12,258 cases, 0 failed; 230 of 230 equivalences and rules verified; the translation results and SQL size baselines are unchanged.make check-cipasses.