Repository navigation
feat(syntax): check Snowflake views and streams against their grammar - #199
Merged
Merged
Conversation
CREATE STREAM kept everything after STREAM as raw text, so malformed statements were accepted. A stream on a table, view, external, dynamic or event table or a stage now builds a CreateObject: its tags and COPY GRANTS before ON, the source, AT or BEFORE where the source takes it, and the properties that source documents. CREATE OR ALTER STREAM and DEFINE STREAM read a table only. A time travel point may name a STREAM.
CREATE SEMANTIC VIEW was checked against its grammar and then kept as raw text, and DEFINE SEMANTIC VIEW was refused. Both now build a CreateObject whose clauses are properties: tables, relationships, facts, dimensions, metrics and verified queries as lists of their parts, with the item expressions parsed.
…eir grammar Recursive, volatile, secure materialized and interactive materialized views were kept as raw text, and view-level clauses such as COPY = ( ), JOIN POLICY, AGGREGATION POLICY and WITH CONTACT were refused. A Snowflake view now reads its scope, column options, view clauses and query against the grammar of its kind: a materialized view takes CLUSTER BY and no CHANGE_TRACKING, and CREATE OR ALTER VIEW takes only CHANGE_TRACKING and COMMENT. Column policies after the column list, empty column lists and string column names are refused, as Snowflake refuses them.
…mmar ALTER VIEW now reads Snowflake's SET and UNSET of view properties, IF EXISTS, and the name Snowflake lets SET omit. An ALTER VIEW with no action is refused. ALTER MATERIALIZED VIEW reads RECLUSTER and a SET with the name omitted. A CREATE whose name is followed by ON, a stream missing its STREAM keyword, is refused.
Snowflake parses any option, and AT or BEFORE, on every stream source and refuses a misplaced one only after parsing, so the grammar no longer ties options to sources. AT and BEFORE take VERSION, a tag value may be a number, and CREATE OR ALTER STREAM takes tags.
Snowflake parses a CREATE VIEW whose column list follows a view property, such as CHANGE_TRACKING = TRUE ( id ), and refuses a view COMMENT written without =.
Test suites, development scripts and development-only tools (the coverage and format checks, the fuzz targets and the Snowflake recorder) are marked linguist-documentation, so the language bar reflects the code SQLQuack ships.
Snowflake rejects a view's SECURE together with any other property in one ALTER VIEW SET or UNSET, and RECURSIVE after a temporary scope in CREATE, CREATE OR ALTER and DEFINE VIEW, although the documented grammar shows both. Every receipt with either shape is a syntax error, and every single-property SET and UNSET and every plain RECURSIVE view parses, so the parser now refuses exactly these shapes.
…and stream grammar On the pinned evidence the view, stream and semantic view grammar satisfies 1,256 more obligations and accepts 160 fewer statements Snowflake rejects as syntax errors, with no regression; re-record the baseline so check-syntax holds the gain. Seven corpus statements are now refused, as Snowflake's view grammar has no such clause: SECURITY DEFINER or INVOKER and SQL SECURITY, a LOCKING clause, and a view COMMENT without =.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the table grammar, the view, materialized view, stream and semantic view forms were the next ddl gap: Raw fallbacks, false rejects of ALTER VIEW properties, and stream options tied to sources Snowflake does not tie them to. This replaces them with checked grammars that match the receipts: where the documentation shows a shape Snowflake refuses with a syntax error, the grammar refuses it too.
Changes
.gitattributesmarks tests, scripts and dev-only tools as linguist-documentation, so the language bar counts shipped code.Verification
Snapshots on the pinned evidence, main's parser → this head:
New false accepts against receipts: 0. No obligation or parsed case is lost. In the view and stream forms, false accepts go 201 → 42 and false rejects of cases Snowflake parsed 186 → 34.
make check-ciandmake verify-recordedpass; crate tests cover each root cause, including the three refused view shapes.